1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/bat_xfer.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Jun 6 00:04:44 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/b417647b95c4fa921624034c
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Check batch-uploaded filenames for illegal characters/sequences/names

    The BadFilename text.dat is now a format string (prints the bad filename).
    Use the nice progress() display status while searching for duplicate filenames.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Jun 10 13:27:44 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/0c5c140eceeb8012a8083f6a
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Call smb_freefilemem() instead of smb_msgmem() for files

    Not that it really matters, but perhaps it'll matter in the future. And the code reads better.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Oct 23 10:06:56 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/7dc1bc798e5a06e2278711ea
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Fix segfault after batch-upload when no "uploads" dir specified

    When there's no "uploads" directory configured by the sysop, cfg.upload_dir will be set to INVALID_DIR, which cannot be used as an index into cfg.dir[] to determine if the time used for uploading the files should be "given back" to the user.

    In v3.18, we used the first file in the upload queue, if there was one, else fell back to the "uploads" dir (which had to have been defined if there were no files in the queue). So this illegal array indexing was a regression in v3.19.

    Reported by Zoltán Gábor on Facebook

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Oct 16 00:09:51 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/1f506c96b8e314e9089f63d3
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Fix silliness discovered in conversion to JavaScript

    So apparently 23 years ago (almost 24), I made a typo in commit
    7731d16dbbcb7 that broke the batch transfer menu for RIP users.

    Also elminated silly/unnecessary loop-control variable ('done').

    I'm working on a port to JS and noticed these oddities (so far).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jun 12 20:57:16 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/7224004997bf5e2cc83b3496
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Protect the batch download list/queue from exceeding allowed files per day

    Address issue raised in discussion with x-bit regarding issue #938

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jun 12 21:19:25 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/70cfadec8b82dabd56e5b6ce
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Fix off-by-one for batchdownload list/queue size protection

    could allowed max-downloads-per-day + 1 files in queue

    related to issue #938

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net