https://gitlab.synchro.net/main/sbbs/-/commit/4391ca758f32b9af128c87b8
Modified Files:
src/sbbs3/filedat.c
Log Message:
Sorted loadfiles() results were corrupted when detail was < normal
When only reading the index (detail = file_detail_index), smb_getfile() just sets the file->name convenience pointer to point to the name in the index. Then when loadfiles() would sort the list, these pointers would not be adjusted (so they would point to the wrong names) resulting in a corrupted file list (e.g. name/size mismatches and no logical sort order).
The solution is to call smb_getfile() on each file *after* the read index records have been sorted.
This also means that the sort-by-name routines needed to always sort using the index name and not the convenience pointer (which is NULL in this case).
While fixing this, I noticed there was no bounds checking in the loadfiles() and loadfilenames() read-loops, so if the indexes happened to be longer than the total_files value from the status header, a buffer under-alloc/overflow would occur and a likely crash as a result. So stop reading the index when the expected maximum number of index records have been read.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net